Pezzawinkle / PezsMods

Pezzawinkles-Factorio-mods
MIT License
2 stars 1 forks source link

Simple fix for gears. #11

Closed Recon419A closed 3 years ago

Recon419A commented 4 years ago

This fixes the icons and the recipes for mechanical parts and gears with Angel's component overhaul enabled, but not the localizations. This patch set is a lot simpler than the other attempt, and my suggestion is that we merge this instead of that. I'm also going to make some issues to fix various things with the localizations separately.

Pezzawinkle commented 4 years ago

I have made the tweaks, then decided to disable the mechanical part casting... but ill leave that to you if you want to comment that out. Keep in mind that the mod is meant to also now work without bobs (for pure angels industries runs)

Recon419A commented 4 years ago

I have made the tweaks, then decided to disable the mechanical part casting... but ill leave that to you if you want to comment that out.

I think that's a good change, since mechanical parts are a little complex to be directly castable. It's worth noting that it's a breaking change, however, since the old recipe for iron gears was getting converted to a recipe for mechanical parts. I don't think a migration is appropriate since the end product changed (which would mess up production lines), but we should probably warn about the breaking change at least in the changelog.