prune arbitrary leading/trailing whitespace while stripping
filter out empty string by default
NB:
_splitSemiOrComma is used in a lot of places. Contrary to its name, until now it only actually split on commas and not semicolons.
While this change will improve/fix cases where code was written with the expectation that this function split on semicolons, it can also potentially introduce new issues since written code was tested with the old behaviour.
I tested some creature statblocks which seemed to still work fine but things could of course still break on various edge cases or other kinds of entries.
Alternatively, we could rename the existing function to e.g. _splitComma and introduce a new _splitSemiOrComma version and start using that on a case-by-case basis for a "safer" migration.
MrVauxs
commented
1 year ago
NB:
_splitSemiOrCommais used in a lot of places. Contrary to its name, until now it only actually split on commas and not semicolons.While this change will improve/fix cases where code was written with the expectation that this function split on semicolons, it can also potentially introduce new issues since written code was tested with the old behaviour.
I tested some creature statblocks which seemed to still work fine but things could of course still break on various edge cases or other kinds of entries.
Alternatively, we could rename the existing function to e.g.
_splitCommaand introduce a new_splitSemiOrCommaversion and start using that on a case-by-case basis for a "safer" migration.