search

Pf2eToolsOrg / Pf2eTools

A site dedicated to making playing games with your friends as easy as possible.
https://pf2etools.com/
MIT License
97 stars 63 forks source link

Correctly render Witch Hexes creature spellcasting entries #302

Closed Jnosh closed 1 year ago

Jnosh commented 1 year ago

Witch Hexes spellcasting entries are currently rendered as Witch Hexes Spells as we add the trailing Spells in the renderer.

This PR takes the approach of simply storing the full spellcasting name in the data which the renderer outputs unmodified. The current data is updated via update-jsons.js and the text converter is adjusted as well.

Alternatively, Witch Hexes could also be special cased in the renderer or a data property added if Spells should be appended when rendering.

MrVauxs commented 1 year ago

I think this is a quite unneeded data addition.

You can solve this by having the auto-generated name append the Spells itself. No need to add thousands of new strings.

MrVauxs commented 1 year ago

Closing as it has been solved by #303.