search

Pf2eToolsOrg / Pf2eTools

A site dedicated to making playing games with your friends as easy as possible.
https://pf2etools.com/
MIT License
92 stars 57 forks source link

Adding adventure link functionality #340

Closed skeetcha closed 6 months ago

skeetcha commented 8 months ago

Using the {@adventure} tag would not link to the adventure if it existed. Changed the path of the generated hyperlink to use the page and hash variables already created but unused.

Spappz commented 6 months ago

There are a bunch of @book tags around, but there shouldn't be; the book.html page was removed quite a while ago for OGL compliance. Similarly, the @adventure tag is effectively redundant due to the absence of any @adventure content, either by Paizo or in our homebrew repo. I obviously can't be certain, but I'm fairly sure that no one's made private homebrew for it, either.

So, this will be a wontfix. I'll delete the remaining @book tags in the data for next update, but, since Pf2eTools is no longer maintained, I don't think anyone's gonna be diving into the (unmaintainable!) code to give a 'proper' fix. With some luck, we won't have these problems at all in our (actively developed) rewrite!

If you'd like to fiddle with something more complex in the interim, feel free to drop by our Discord server and have a chat!