Feature for API keys in Ios

Ph3nol / NotificationPusher

Standalone PHP library for easy devices notifications push.

MIT License

1.18k stars 273 forks source link

Feature for API keys in Ios #146

Open knvpk opened 7 years ago

knvpk commented 7 years ago

Apple has started giving API keys instead of certificates for push notification. This makes life easy rather than working with request signing, changing them from cer to p12 etc etc.

Also refer this https://github.com/davibennun/laravel-push-notification/issues/173

knvpk commented 7 years ago

Is anybody there?

seyfer commented 7 years ago

@pavankumarkatakam, I need to have a look at it. If any participants would like to add their contributions - you are welcome.

seyfer commented 7 years ago

@Ph3nol, I would try to implement new API way to work with APNS with help of this library - edamov/pushok

Seems like Zend library not actively supported https://github.com/zendframework/ZendService_Apple_Apns/issues/45#issuecomment-271151461 So, when edamov/pushok will implement a functionality to work with certificates - I think it's a good idea to replace Zend with edamov/pushok completely in future.

seyfer commented 7 years ago

@Ph3nol, since edamov/pushok supports only php 7.0+ I will mark our v2.3 to support only 7.0+ also.

seyfer commented 7 years ago

@Ph3nol, or it's better to mark it as v3.0, because, for example, this popular laravel module https://github.com/davibennun/laravel-push-notification depends on our 2.* version.

And if we will release v2.3 with php 7.0 minimum - it will break laravel-push-notification.

I think there is a lot more packages which depend on Ph3nol/NotificationPusher v2.. And they are for php 5.. That's why v3.0 will be better.

Jacse commented 6 years ago

Any update on this, @seyfer ?

seyfer commented 6 years ago

Well, it needs to be done, definitely. But I need to have resources for that. What I need: time, android and ios devices(don't have it) and simple ionic app to just accept notifications (do not have experience with it at the moment, but will).

The plan is:

to buy some old iPhone first because it needs to be connected to PC for development.
then have a look at ionic and craft simple app for testing (which is simple) Only after that, I would dive into development, when I will be able to test what I'm developing. At the moment when I have written messages above I had an ios device, now I haven't it, and also have less time.

What I could do is to add TODO section in the readme and hopefully, somebody would like to participate.

eerison commented 5 years ago

@seyfer Thanks for your comment about edamov/pushok I was problem with another lib that was using old apple api and my application stop send notification :(

So I change to this lib (edamov/pushok) and to be working perfectly :)

But I can help you implement this lib here and make new release 3.x

seyfer commented 5 years ago

@eerison you can, if you have time. It is about replacing ApnsAdapter implementation here to use edamov/pushok instead of Zend_Apns, with the same interface.