search

Ph3nol / NotificationPusher

Standalone PHP library for easy devices notifications push.
MIT License
1.18k stars 273 forks source link

Update dependencies and allow symfony/console v5 #198

Closed red-led closed 3 years ago

seyfer commented 3 years ago

@red-led hey, thank you for the contribution.

could you please have a look at why tests are failing?

Failure (9 tests, 34/34 methods, 0 void method, 0 skipped method, 0 uncompleted method, 0 failure, 34 errors, 0 exception)!
red-led commented 3 years ago

@seyfer, looks like errors are related to xdebug config:

==> Error E_WARNING in /home/travis/build/Ph3nol/NotificationPusher/vendor/atoum/atoum/classes/test.php on line 1355, generated by file /home/travis/build/Ph3nol/NotificationPusher/vendor/atoum/atoum/classes/test.php on line 1355: Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'

xdebug.mode=coverage is new for xdebug3. I have no idea, how to change it in travis builds :(

seyfer commented 3 years ago

@red-led thank you, I will have a look this weekend!

seyfer commented 3 years ago

@red-led please add this code

env:
    global:
        - XDEBUG_MODE=coverage

in .travis.yml after php section. Should work after. :)

If it will not work, try to do this https://travis-ci.community/t/warning-xdebug-mode-coverage-has-to-be-set-in-php-ini/10919/8?u=seyfer

seyfer commented 3 years ago

@red-led now you have problem with composer install.

Could you please try to update the only composer.json but revert composer.lock changes? It is wrong, I know, but might fix the build.

red-led commented 3 years ago

@seyfer done.

Have you considered not storing composer.lock in git at all?

red-led commented 3 years ago

@seyfer, will you publish new release with this changes?

goraxan commented 2 years ago

@seyfer I also need the new release with this change, please :)