Ph3nol / WebVMGenerator

A generator service to make your Vagrant + Puppet web Virtual Machines easily.
MIT License
37 stars 5 forks source link

mytop - htop for mysql #22

Open gimler opened 11 years ago

Ph3nol commented 11 years ago

Thanks for this PR.

The better way for installing mytop and htop is to purpose them as config optional packages.

Let's add it here for example: https://github.com/Ph3nol/WebVMGenerator/blob/master/src/Sly/Bundle/VMBundle/Config/Config.php#L159

Can you adapt your PR?

Thank you so much.

gimler commented 11 years ago

The point admin install htop and atop. Should i split this into htop, atop, and mytop this will end up in 1000 packages i think?

For me it was a liddle bit confusing what means package admin? I think a good idea is to provide sone kind of bootstrap tooltip.

So i have added mytop to mysql so i think it is the right place.

So the main question is should we go the way of 1000 small packages (more configurable better specialized packages)

Or should we provide group based packages (less options better overview)

We could also add mytop as child package from mysql in the gui so when i clicked mysql (the childs would be expand and all checked) but i can deselect child packages.

What do you mean?

Ph3nol commented 11 years ago

My bad, I definitely agree with your point of view.

I think the best solution could be yours, from Puppet MySqlElement, with checking admin option selection like this:

{% if 'admin' in vm. systemPackages %}
system::package { "mytop":
    require => Package["mysql"]
}
{% endif %}

What do you think about it?