search

Phala-Network / khala-parachain

Khala parachain
Apache License 2.0
27 stars 19 forks source link

Fix XCM message forward #295

Closed tolak closed 1 year ago

tolak commented 1 year ago

This PR is going to fix a bug in the XCM message forwarder exists in SubBridge.

When forwarding XCM message from other chains like Ethereum, we hardcode the proofSize when constructing the XCM message. In XCM V3, this should be a meaningful value rather than 0. Giving 0 will lead to a Barrier error on the dest chain. See this record.

tolak commented 1 year ago

LGTM. Btw, where does the magic number 2e6 come from?

We don't have an accurate number for this, this value is used on our front-end and works well. I heard that other values may also work, like 65536, haven't tested it though.