search

Phalcode / gamevault-app

Frontend for the self-hosted gaming platform for drm-free games
https://gamevau.lt
Other
402 stars 18 forks source link

Uninstalling game leaves empty folder #350

Closed KairuByte closed 8 months ago

KairuByte commented 10 months ago

Describe the bug Similar to #241, when a game is uninstalled an empty folder remains.

To Reproduce Steps to reproduce the behavior:

  1. Install a game
  2. Uninstall that same game
  3. Folder remains

Expected behavior If the uninstall is successful, all files are already deleted. At which point the folder is just clutter and should be deleted as well.

Alfagun74 commented 10 months ago

what game type does this happen for?

KairuByte commented 10 months ago

Actually this may be an edge case? It's a windows installer, but I uninstalled after replacing the installer with a portable version.

It didn't ask for an uninstaller, it just deleted the files.

I'm fine with that, since 99% of the time it's just files that needs to be removed by the uninstaller anyway, but that means there's another bug involved.

Yelo420 commented 9 months ago

Only the server checks whether it is an installer or portable and forwards this information to the client. Gamevault Client only deletes the files without asking for an uninstaller if it is a windows portable. The game was probably recognized incorrectly (or false flagged)

Alfagun74 commented 8 months ago

@KairuByte

Can you still reproduce this and see it as a problem or can this be closed?

Alfagun74 commented 8 months ago

also see #359

Alfagun74 commented 8 months ago

Cannot reproduce, author not responding.