Phalcode / gamevault-app

Frontend for the self-hosted gaming platform for drm-free games
https://gamevau.lt
Other
402 stars 18 forks source link

Confirm to delete the remaining files when Uninstalling a Windows Setup Game #359

Closed Alfagun74 closed 8 months ago

Alfagun74 commented 8 months ago

I had a rather unpleasant experience uninstalling my Windows Setup Game. I accidentally selected the wrong uninstall executable and closed it. GameVault detected the uninstaller completed and hard-wiped the installation folder after without my confirmation, keeping all the install stuff in the registry...

Alfagun74 commented 8 months ago

@Yelo420 Would be nice if we could fit this into this release.

Yelo420 commented 8 months ago

GameVault detects any Files in the Install folders (Because it has no chance to diff trash from the real game). So if the User would click on "Do you want to delete remaining files" - NO The game would remain installed.

Alfagun74 commented 8 months ago

That's okay because I selected wrong uninstaller and there is still data

Yelo420 commented 8 months ago

Because this popup would appear with every Windows setup uninstall, it could happen that the user accidentally clicks on NO (uninstall has gone through but there are remaining files). From then on, the user has no chance of deleting the game via the UI and would have to go to the file system.

Alfagun74 commented 8 months ago

I see.. Another solution would be to put the remaining gamefiles into Windows trash instead of permanently deleting them. This way if I selected the wrong exe accidentally I can still recover them, no popup needed.

Alfagun74 commented 8 months ago

Or maybe just ask for "are you sure you want to uninstall the game using Uninstall.exe" after selecting the exe. So a misclick doesn't uninstall immediately.

Alfagun74 commented 8 months ago

We decided to do both.

Yelo420 commented 8 months ago

Done