search

Phalcode / gamevault-app

Frontend for the self-hosted gaming platform for drm-free games
https://gamevau.lt
Other
257 stars 12 forks source link

Gamevault crashes when trying to extract games #407

Closed casudo closed 1 month ago

casudo commented 1 month ago

Describe the bug Gamevault crashes when trying to extract games. It seems like it was extracted successfully when I open the download path, because the "Extract" folder is filled with the contents of the .zip, but the frontend crashes after ~2 sec when I click the extract button. Therefore, even if it seems like the game extracted, I cannot install it via Gamevault.

To Reproduce Steps to reproduce the behavior:

  1. Go to Downloads
  2. Click on "Extract"

Expected behavior The game should be extracted and ready to install via the GUI.

Screenshots image

Desktop (please complete the following information):

casudo commented 1 month ago

Update: I've removed the whole game and re-downloaded it. This time I saw the progress bar for extracting and also the "gamevault-metadata" appeared with its contents inside the "Extract" folder. In the end I could install the game successfully.

The only thing that bothers me now that the state of the game in the "Downloads" tab still shows "Extracted" rather than "Installed". image

Yelo420 commented 1 month ago

Describe the bug Gamevault crashes when trying to extract games. It seems like it was extracted successfully when I open the download path, because the "Extract" folder is filled with the contents of the .zip, but the frontend crashes after ~2 sec when I click the extract button. Therefore, even if it seems like the game extracted, I cannot install it via Gamevault.

To Reproduce Steps to reproduce the behavior:

  1. Go to Downloads
  2. Click on "Extract"

Expected behavior The game should be extracted and ready to install via the GUI.

Screenshots image

Desktop (please complete the following information):

  • Windows 10

Can you provide more infos about the crash? Any error message you've got? Maybe you can take a look into the errorlogs. You can find them here: Github Version: %USERPROFILE%\AppData\Roaming\GameVault\errorlog MC Store Version: %USERPROFILE%\AppData\Local\Packages\Phalcode.174950BD81C41_dymsgn3qpfjxc\LocalCache\Roaming\GameVault\errorlog

Do you have auto extract enabled? Are you able to reproduce this crash? (Because i can't)

casudo commented 1 month ago

@Yelo420

Can you provide more infos about the crash? Any error message you've got? Maybe you can take a look into the errorlogs. You can find them here: Github Version: %USERPROFILE%\AppData\Roaming\GameVault\errorlog

I don't have the errorlog file weirdly.

Do you have auto extract enabled?

No.

Are you able to reproduce this crash? (Because i can't)

Since I re-downloaded the games, I cannot reproduce it. Maybe there were some faulty or missing bits.

Yelo420 commented 1 month ago

Since I re-downloaded the games, I cannot reproduce it. Maybe there were some faulty or missing bits.

Normally even if there are uncaught errors, there should be a error window. Its strange that the Client crashed silent.

Yelo420 commented 1 month ago

I will close the ticket for now. If it occurs again, please open a new one. Also make a backup of the incorrect data so that I can analyze it in more detail.

The only thing that bothers me now that the state of the game in the "Downloads" tab still shows "Extracted" rather than "Installed".

This seems to be a bug (But don't worry, only in the UI). Could it be, that the game type is a game with a setup executable?

Yelo420 commented 1 month ago

I digged a bit around and was actually able to reproduce the error. Should be fixed now.

Yelo420 commented 1 month ago

The only thing that bothers me now that the state of the game in the "Downloads" tab still shows "Extracted" rather than "Installed".

Also fixed

casudo commented 1 month ago

@Yelo420 Awesome job, thank you for fixing it that fast! May I ask what caused this bug?

Yelo420 commented 1 month ago

Without going into too much detail, there was a rather harmless data error, which was unfortunately thrown in the progress update event of the 7zip subprocess. This led to a chain of errors that this subprocess also hard crashed the main process. Nothing the global error handler could catch.

casudo commented 1 month ago

@Yelo420 It seems like the bug with the wrong state of the game in the downloads persists in v0.10.1.0.

I've just installed a game which, after installation, correctly showed the "State: Installed" status. After restarting GameVault, its back to "State: Extracted".

Yelo420 commented 1 month ago

In this case its intentional.

The download card should exist independently and give the user the possibility to edit his “download” even after installation. For example: After a portable game has been installed, the Extract folder no longer exists. So the game is installed, BUT the download is in status downloaded again. The state switch to "Installed" right after installation is just for the userflow.

If you have any ideas for changes, please let us know and we will discuss them internally.

casudo commented 1 month ago

In this case its intentional.

The download card should exist independently and give the user the possibility to edit his “download” even after installation. For example: After a portable game has been installed, the Extract folder no longer exists. So the game is installed, BUT the download is in status downloaded again. The state switch to "Installed" right after installation is just for the userflow.

If you have any ideas for changes, please let us know and we will discuss them internally.

Alright, sounds great. Maybe a counter and date displaying next to the downloaded game to inform the user that he/she already installed the game sometime.