search

Phalcode / gamevault-app

Frontend for the self-hosted gaming platform for drm-free games
https://gamevau.lt
Other
398 stars 18 forks source link

QoL changes to improve setup and game installation experience #414

Closed LostSoulfly closed 2 months ago

LostSoulfly commented 5 months ago

Small and simple QoL change to pick the (in my experience), most likely installation files.

LostSoulfly commented 5 months ago

Whoops, I didn't realize subsequent changes would be added to this push.

Sorry if it's a bit messy, I've never worked with xaml before. Basically, I wanted to polish up the setup experience as well as add some QoL fixes.

Alfagun74 commented 4 months ago

Hi there,

Thanks so much for your contribution! I noticed that everything is squashed into a single branch, which makes it a bit challenging to review. Could you please add more comments to your changes to help us understand your reasoning?

Also we usually prefer contributions that reference a ticket on our board.

Thanks again!

sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

LostSoulfly commented 2 months ago

Hey, I appreciate the effort you guys are putting into this software. It's great!

I already put all the free time I was willing to contribute into this PR and believed I was descriptive enough about each of my commits. I will opt to maintain my own fork for myself and my friends going forward as long as I use GameVault, so I've closed this PR.

Thanks.

Alfagun74 commented 2 months ago

I'm really sorry this has been waiting for so long. Having everything in a single PR without references to GitHub issues or at least some comments explaining what you were trying to achieve definitely make it harder to review, especially since we are also actively working on a huge update right now. We will definitely take a closer look and draw some inspiration if we find anything useful, if you don't mind.