Phalcode / gamevault-app

Frontend for the self-hosted gaming platform for drm-free games
https://gamevau.lt
Other
404 stars 18 forks source link

IO Error on download loops endlessly #456

Open KairuByte opened 6 days ago

KairuByte commented 6 days ago

Describe the bug
The GV client can enter a state where it repeatedly attempts to download a file without having the necessary permissions to write it, resulting in excessive API calls and potential performance issues.

To Reproduce
Steps to reproduce the behavior:

  1. Start a download of a large file (e.g., 77GB) using the GV client.
  2. Ensure that the file system has a write permission issue (e.g., file lock or insufficient storage).
  3. Observe the client as it attempts to download the file.
  4. Notice that the client repeatedly hits the API endpoint multiple times a minute without successfully writing the file.

Expected behavior
The client should stop attempting to download the file when it encounters a write permission issue or file lock, rather than continuously retrying and causing unnecessary API calls.

Additional context
Suggestions:

Yelo420 commented 3 days ago

So would a targeted query for repeatedly IO errors be the solution here? I said “repeatedly” because it can happen that the file is only blocked for a short time for various reasons.