search

PhamNguyenDuyTien / df-frontend-2023

https://df-frontend-2023-alpha.vercel.app
0 stars 0 forks source link

Submission assignment 3 #3

Open PhamNguyenDuyTien opened 1 year ago

PhamNguyenDuyTien commented 1 year ago

Link demo: https://df-frontend-2023-assignment-3.vercel.app/

tienan92it commented 11 months ago

Hello @PhamNguyenDuyTien , great work! Below is some feedback for your assignment.

Requirements

Final result: ✅ passed 90% of requirements

Feedback

  1. Enable noImplicitAny to reveal the implicit any types. https://github.com/PhamNguyenDuyTien/df-frontend-2023/blob/18b44d8102bd5d8a87fdd402b5dd6685fa26a2ba/assignment-3/tsconfig.json#L15 https://github.com/PhamNguyenDuyTien/df-frontend-2023/blob/18b44d8102bd5d8a87fdd402b5dd6685fa26a2ba/assignment-3/src/components/Modal/Modal.tsx#L3 https://github.com/PhamNguyenDuyTien/df-frontend-2023/blob/18b44d8102bd5d8a87fdd402b5dd6685fa26a2ba/assignment-3/src/components/Bookstore/Bookstore.tsx#L5

  2. No need to explicitly declare the type for primitive values. https://github.com/PhamNguyenDuyTien/df-frontend-2023/blob/18b44d8102bd5d8a87fdd402b5dd6685fa26a2ba/assignment-3/src/components/Bookstore/Bookstore.tsx#L24 https://github.com/PhamNguyenDuyTien/df-frontend-2023/blob/18b44d8102bd5d8a87fdd402b5dd6685fa26a2ba/assignment-3/src/components/Bookstore/Bookstore.tsx#L26 https://github.com/PhamNguyenDuyTien/df-frontend-2023/blob/18b44d8102bd5d8a87fdd402b5dd6685fa26a2ba/assignment-3/src/components/Bookstore/Bookstore.tsx#L30

  3. Unexpected console statement https://github.com/PhamNguyenDuyTien/df-frontend-2023/blob/18b44d8102bd5d8a87fdd402b5dd6685fa26a2ba/assignment-3/src/components/Modal/ModalDelete.tsx#L22