Phando / Streamdeck-Stonks

Streamdeck plugin stock ticker to watch your assets (market and crypto)
MIT License
25 stars 4 forks source link

Missing Currencies? #10

Closed Phando closed 2 years ago

Phando commented 2 years ago

If there is a currency you would like to see, please mention it in this thread.

ViZ83600 commented 2 years ago

UBX FUN GRT QSP

Please...

Phando commented 2 years ago

@ViZ83600 This thread is intended missing currencies, not missing stock and crypto symbols. It looks like FUN and UBX are working. If you enter QSP as QSP-UN.TO it produces results, but I am not sure that is the same ticker. As for GRT-USD, The Graph (coin) or GRT the mutual fund. Neigher GRT is available through the API I am using. With some work I can bring more symbols online in the future. Thanks for the feedback and for using the plugin.

Screen Shot 2021-12-30 at 5 12 50 PM

PawelWozniak commented 2 years ago

Could you please add PLN - Polish zloty. I would like to see a chart for EUR/PLN like here https://www.bankier.pl/waluty/kursy-walut/forex/EURPLN

Phando commented 2 years ago

@PawelWozniak It will be in the next release. Thank you for using the plugin!

PawelWozniak commented 2 years ago

@PawelWozniak It will be in the next release. Thank you for using the plugin!

Thank you @Phando . I have tested all finance plugins for Stream Deck and this one has the best UI. Clear and easy to understand. Waiting for a new release then.

PawelWozniak commented 2 years ago

@Phando Got new version but it is not showing values.

2022-07-21_09h20_13 2022-07-21_09h29_02

EUR/PLN should be about 4,77 and PLN/EUR 0,21

For USD it is showing an invalid value:

2022-07-21_09h22_45 2022-07-21_09h29_30

Currently USD/PLN is about 4,67; PLN/USD about 0,21

Phando commented 2 years ago

The plugin does not do straight conversions like that. It needs to be based on a ticker. The plugin is using the Yahoo Finance API. When things aren't found it is best to look for your ticker there. I found EUR/PLN is EURPLN=X and USD/PLN is PLN=X. Give it a try with those symbols and let me know if you don't see the right values.

[image: Screenshot 2022-07-21 165928.png]

On Thu, Jul 21, 2022 at 12:26 AM Paweł Woźniak @.***> wrote:

@Phando https://github.com/Phando Got new version but it is not showing values. [image: 2022-07-21_09h20_13] https://user-images.githubusercontent.com/5740564/180154087-1220b130-f000-4b89-b18b-fdf0087bcb04.png EUR/PLN should be about 4,77 and PLN/EUR 0,21

For USD it is showing an invalid value: [image: 2022-07-21_09h22_45] https://user-images.githubusercontent.com/5740564/180154375-eb525880-2198-4ae6-b44b-3260e338ca0e.png Currently USD/PLN is about 4,67; PLN/USD about 0,21

— Reply to this email directly, view it on GitHub https://github.com/Phando/Streamdeck-Stonks/issues/10#issuecomment-1191139965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUXMGBPOAMVUFI52XBNRDVVD3SBANCNFSM5KRKIWVA . You are receiving this because you were mentioned.Message ID: @.***>

PawelWozniak commented 2 years ago

I wasn't aware of that. Got it working but have different values.

2022-07-22_09h59_29

I have the same value as on Yahoo when i choose US Dollar as currency

2022-07-22_10h14_06

For Polish Zloty it is completely unexpected result:

2022-07-22_10h15_59

Is there additional calculation based on selected currency then?

There is small visual glitch with such long name like EURPLN=X:

2022-07-22_10h07_21

compared to shorten name:

2022-07-22_10h10_12

Overlay 2hr is not visible for long names. Maybe you could add black background for that mark. Then it will cut out symbol name but it is not that big issue I think.

Phando commented 2 years ago

Thanks for all the feedback. The following changes will be in the next build.

Fixes:

On Fri, Jul 22, 2022 at 7:28 AM Joe Andolina @.***> wrote:

Are the numbers you are seeing on yahoo finance in usd? That might be why they are different from what it is showing in the plugin set to eur.

Would it be okay if I took off the =x at the end of these tickers? That will make a little more space

On Jul 22, 2022, at 1:13 AM, Paweł Woźniak @.***> wrote:



I wasn't aware of that. Got it working but have different values. [image: 2022-07-22_09h59_29] https://user-images.githubusercontent.com/5740564/180393695-14819e90-ec85-4431-85c5-2d3ce019997e.png There is small visual glitch with such long name like EURPLN=X: [image: 2022-07-22_10h07_21] https://user-images.githubusercontent.com/5740564/180394117-a02d1d88-b580-4a45-bb46-626ab011ec8d.png compared to shorten name: [image: 2022-07-22_10h10_12] https://user-images.githubusercontent.com/5740564/180394546-246fe663-028d-48d8-8701-8d1d03a196df.png

Overlay 2hr is not visible for long names. Maybe you could add black background for that mark. Then it will cut out symbol name but it is not that big issue I think.

— Reply to this email directly, view it on GitHub https://github.com/Phando/Streamdeck-Stonks/issues/10#issuecomment-1192306417, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUXMFKBZLU5G6WXT6V5WTVVJJ2PANCNFSM5KRKIWVA . You are receiving this because you were mentioned.Message ID: @.***>

radzio commented 2 years ago

@Phando

There is another issue with FIAT currencies

USD/PLN results in wrong title:

CleanShot 2022-09-07 at 10 23 32

CleanShot 2022-09-07 at 10 24 14

It would be great if we could override the title settings for given key. So that I can change PLN=x which is truncated to PLN to USDPLN or USD/PLN

Phando commented 2 years ago

@radzio I just added a 'label' field. It defaults to the ticker then if you type in it, you can choose any label you want. It is live in release 1.1.6.

Phando commented 2 years ago

Are the numbers you are seeing on yahoo finance in usd? That might be why they are different from what it is showing in the plugin set to eur.

Would it be okay if I took off the =x at the end of these tickers? That will make a little more space

On Jul 22, 2022, at 1:13 AM, Paweł Woźniak @.***> wrote:

 I wasn't aware of that. Got it working but have different values.

There is small visual glitch with such long name like EURPLN=X:

compared to shorten name:

Overlay 2hr is not visible for long names. Maybe you could add black background for that mark. Then it will cut out symbol name but it is not that big issue I think.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.