Phando / Streamdeck-Stonks

Streamdeck plugin stock ticker to watch your assets (market and crypto)
MIT License
25 stars 4 forks source link

Doesn't work #22

Closed jjvaillancourt00 closed 1 year ago

jjvaillancourt00 commented 2 years ago

Doesn't work since I updated my streamdeck to the 6.0 image

Phando commented 2 years ago

Uh oh, I haven’t upgraded, I’ll take a look. Thanks for the heads up.On Nov 15, 2022, at 7:23 AM, jjvaillancourt00 @.***> wrote: Doesn't work since I updated my streamdeck to the 6.0

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

PawelWozniak commented 2 years ago

I can confirm that. Since updating to version 6 it stopped working.

pedropombeiro commented 2 years ago

This isn't the only stocks plugin that stopped working. I wouldn't be surprised if this had to do with the fact that apparently with Stream Deck 6 CIRS headers started being enforced. I also needed to make some adjustments in a couple of personal plugins in order to unblock them (in one case I need to add an Nginx proxy in front of the REST service to handle the CORS headers logic).

Phando commented 2 years ago

Thank you all for the info. I started looking into this yesterday. Currently the plugin won’t even log to the console. @pedro, I’ll look into the headers as well. I hope to be back in action shortly.On Nov 16, 2022, at 6:53 AM, Pedro Pombeiro @.***> wrote: This isn't the only stocks plugin that stopped working. I wouldn't be surprised if this had to do with the fact that apparently with Stream Deck 6 CIRS headers started being enforced. I also needed to make some adjustments in a couple of personal plugins in order to unblock them (in one case I need to add an Nginx proxy in front of the REST service to handle the CORS headers logic).

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Phando commented 2 years ago

@pedropombeiro You were right, it was a CORS issue. Everything will be fixed in the next release of the Elgato software. Also more features in Stonks v1.1.7

PawelWozniak commented 1 year ago

With today's release of Stream Deck 6.0.1.17722 it works again. Good job. Thank you.

jjvaillancourt00 commented 1 year ago

Working again. Thank you! image

Phando commented 1 year ago

Thank you all for the support. Fixed with the release of Streamdeck 6.0.1(17722).