search

Phando / Streamdeck-Stonks

Streamdeck plugin stock ticker to watch your assets (market and crypto)
MIT License
25 stars 4 forks source link

Currency symbol #26

Closed ZyberSE closed 1 year ago

ZyberSE commented 1 year ago

If Yahoo is displaying an international stock in the local currency and I choose that currency in the Stream Deck config it will be incorrectly converted as the plugin thinks the original value is in USD. So for those stocks I need to select USD as currency for the value to be correct but then have incorrect currency symbols.

Phando commented 1 year ago

Good catch. Can you please send me an email example of how to recreate what you are seeing?JoeOn Mar 28, 2023, at 4:25 AM, ZyberSE @.***> wrote: If Yahoo is displaying an international stock in the local currency and I choose that currency in the Stream Deck config it will be incorrectly converted as the plugin thinks the original value is in USD. So for those stocks I need to select USD as currency for the value to be correct but then have incorrect currency symbols.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

ZyberSE commented 1 year ago

Yeah sure, to what address?

Phando commented 1 year ago

You can just reply in this thread. I don't need a lot of details, just what you are looking for, and what went wrong.

On Tue, Mar 28, 2023 at 11:49 AM ZyberSE @.***> wrote:

Yeah sure, to what address?

— Reply to this email directly, view it on GitHub https://github.com/Phando/Streamdeck-Stonks/issues/26#issuecomment-1487439029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUXMDPVSSOGYA2X7VZ5GLW6MXENANCNFSM6AAAAAAWKNTD6Q . You are receiving this because you commented.Message ID: @.***>

ZyberSE commented 1 year ago

Ahh oki. So if you add ticker "SBB-B.ST" which is a Swedish company it will be listed as shown in Yahoo Finance, i.e. with correct numbers in SEK, but your plugin thinks it's in USD and adds a $ sign. I of corse would like to see the local currency sign appended (kr or SEK). But when selecting that you're attempting to convert the already correct number.

So if there was an option, or better yet, logic to identify what currency Yahoo is reporting the stock in and updated settings accordingly. So in this case it would automatically select "SEK" and not do any conversion, if however I would select USD you would run the conversion.

So logic vice this shouldn't require too much effort as longs as current currency is reported in the response object.

A side question, is there a way to display the daily graph starting from opening, not last 24h and show the development in % since yesterdays close, under the current value?

ZyberSE commented 1 year ago

Have you had a chance to look into this yet? Let me know if you need any more information from me.

Phando commented 1 year ago

Apologies, I have not had a chance to look yet. I need to clear up some real job things before I can circle back to the plugin. That said, I understand the problem and am hoping it is an easy fix.

On Wed, Apr 5, 2023 at 12:42 AM ZyberSE @.***> wrote:

Have you had a chance to look into this yet? Let me know if you need any more information from me.

— Reply to this email directly, view it on GitHub https://github.com/Phando/Streamdeck-Stonks/issues/26#issuecomment-1497058923, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUXMFPKEWLKC5WT4OPML3W7UO5PANCNFSM6AAAAAAWKNTD6Q . You are receiving this because you commented.Message ID: @.***>

Phando commented 1 year ago

Thanks for finding the bug A fix will be in v1.1.9