Phando / Streamdeck-Stonks

Streamdeck plugin stock ticker to watch your assets (market and crypto)
MIT License
25 stars 4 forks source link

Not working here either for the past week, maybe a bit longer. #36

Closed TheSimArchitect closed 1 year ago

TheSimArchitect commented 1 year ago

image

Not working here either for the past week, maybe a bit longer.

Phando commented 1 year ago

Thanks for hanging in there, I am working on it. The API that provides the data changed its format.

matextrem commented 1 year ago

@Phando Temporary Fix - > https://github.com/Phando/Streamdeck-Stonks/pull/37

TheSimArchitect commented 1 year ago

Thanks! Didn't work though.

image

matextrem commented 1 year ago

How did you try it? I haven't done a release, just creating a PR.

TheSimArchitect commented 1 year ago

Oh? I downloaded from github manually and installed the latest available version you uploaded 3 hours ago?

image

I thought you expected me to do that to test it 😬

matextrem commented 1 year ago

Nope, that was created by @Phando. I'm waiting for him to review it and create a new one.

matextrem commented 1 year ago

@TheSimArchitect Could you please download the fix from here and let me know if it works ?

TheSimArchitect commented 1 year ago

Yes, it does! Thanks!!

image

As you can see it looks funny currency wise (not BTC) depending on the day/time of the day (it was this way before).

Phando commented 1 year ago

Thank you all for looking into this and for the PR. I am going to do a little testing and run with the v6 changes if all looks good.

V10 looks promising and has a way better return than v6 and v7, but it only allows for single quotes per request. It would cool to run with that, but I think we will hit API limits.

@TheSimArchitect What will fix the currency issue you are seeing?

TheSimArchitect commented 1 year ago

Thanks @Phando !

As you can see the charts for fiat currencies are flat and the values won't update during non business hours and weekends (it never worked).

It's funny because it's not even the minute chart, but the 5 days and one month ones (yearly shows up), which should have the information visible doesn't, as you can see, the entire chart is wiped and you only get the "last quote" (from whenever it is) and a horizontal line.

Phando commented 1 year ago

Fixed in v1.1.14 Thank you for your patience