search

Phando / Streamdeck-Stonks

Streamdeck plugin stock ticker to watch your assets (market and crypto)
MIT License
25 stars 4 forks source link

[Finance API] Temporary Fix #37

Closed matextrem closed 1 year ago

matextrem commented 1 year ago

It seems there were some updates to the API that broke the current behavior :

Disclaimer: This is a temporary fix and needs to be updated once Yahoo team has fixed the issues described above.

image

Phando commented 1 year ago

A PR from the community... this is kind of amazing. Thank you. You are right that the v6 API gets the plugin working again for quotes, while the charts needs to be on v7

Did you give the v1.1.12 a try? Were you still seeing 404s? I was able to extract the crumb and send it back which fixed my instance. The crumb was available from both:

https://query1.finance.yahoo.com/v1/test/getcrumb
https://finance.yahoo.com/quote/%5EGSPC/options (needs some regex)
matextrem commented 1 year ago

Hey @Phando ! I tried the v1.1.12 version but still getting 404s.

The thing is the crumb endpoint is not returning the info properly so response.text() returns an empty string.

image
Phando commented 1 year ago

Sounds like we have a fix. I will get the crumb from the alternate url and apply some of the other fixes presented in the PR.

On Mon, May 15, 2023 at 9:18 AM Mati Dastugue @.***> wrote:

Hey @Phando https://github.com/Phando ! I tried the v1.1.12 version but still getting 404s.

The thing is the crumb endpoint is not returning the info properly so response.text() returns an empty string. [image: image] https://user-images.githubusercontent.com/11525018/238409464-3f83269a-979a-4f7b-99dd-0feab08efcca.png

— Reply to this email directly, view it on GitHub https://github.com/Phando/Streamdeck-Stonks/pull/37#issuecomment-1548164064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUXMB2SF3BBTJLVT6KC63XGJJNRANCNFSM6AAAAAAYAFR4PM . You are receiving this because you were mentioned.Message ID: @.***>

Phando commented 1 year ago

Landed a lot of these changes in v1.1.14 Thank you @matextrem