[BUG]: PJPipe incompatible with newest version of reproject

PhangsTeam / pjpipe

Pipeline for processing JWST imaging data, tailored for nearby galaxies. Built for PHANGS

https://pjpipe.readthedocs.io/en/latest/

GNU General Public License v3.0

14 stars 1 forks source link

[BUG]: PJPipe incompatible with newest version of reproject #70

Closed Stargrazer82301 closed 2 weeks ago

Stargrazer82301 commented 1 month ago

Describe the bug The newest version of reproject, 0.14.0, is incompatible with PJPipe. Specifically, the __init__ for ReprojectArraySubset now expects imin, imax, jmin, and jmax to be provided together as a single variable ,bounds.

To Reproduce Any attempt to run the level matching step in PJPipe.

Expected behavior Not crashing.

thomaswilliamsastro commented 1 month ago

I think this should be part of a larger 'get everything up to scratch for numpy 2.0' update, which I won't have time for for the next couple of weeks. In the meantime, if you just use the pinned versions of the packages from pyproject.toml, things should work for now

Stargrazer82301 commented 1 month ago

Yep, I just force-downgraded reproject to 0.13.0, and it works fine again. Just wanted to let you know what had happened here, to save you coming across it and digging it out for yourself.

Honestly, I kindaenjoyed the novelty of finding a crash not directly caused by the numpy 2.0.0 update...