search

PhanstielLab / plotgardener

https://phanstiellab.github.io/plotgardener/
Other
299 stars 28 forks source link

Fixes #85 #86

Closed EricSDavis closed 1 year ago

EricSDavis commented 1 year ago

Fixes extra page creation on pdf() when using plotHicSquare().

With the help of @sarmapar!

nekramer commented 1 year ago

Thanks for looking into this! That line of code is actually required for plotting without placement. It's nested within logic that makes sure x- and y-coordinates aren't provided, so it will only completely make a new page when you're trying to get a quick look at the plot without page placement in the graphics device. This same logic is included in all major plotting functions.

It's likely that you're getting an extra page if you call pageGuideHide(). I've been aware of that, but can't really do anything due to the nature of grid.