search

Phantom5800 / pmr-tracker

Web based tracker for Paper Mario Randomizer
MIT License
6 stars 12 forks source link

Map Tracker Logic - Reset Should Only Be Done Once #51

Open Phantom5800 opened 2 years ago

Phantom5800 commented 2 years ago

I applied a quick hotfix in 7f3e7234 that fixed a reported issue where json loading would hang the page. This is due to how page resets work in general at the moment.

A longer term solution needs to be put in place, this hotfix also breaks map tracker logic resets, as anything that was previously set accessible does not get reset. The main issue was the frequency of getAvailableChecks being called for as heavy of a function as it is. On a page reload, this function was getting called many hundreds of times.

Phantom5800 commented 2 years ago

After playing through a seed earlier, even with just clicking on things in the tracker there is a fairly noticeable delay. getAvailableChecks needs some optimization work.