Phantom5800 / pmr-tracker

Web based tracker for Paper Mario Randomizer
MIT License
6 stars 12 forks source link

Fixing some issues with right-clicking areas #75

Closed MythicFrog closed 1 year ago

MythicFrog commented 1 year ago

Currently when right-clicking an area with disabled checks the check counters for total/panels/coinsanity can become negative due to forcing the .click() function on them.

There is also an issue with the logic that checks whether or not an input is checked which causes the right click to just toggle every input. This can cause already checked inputs to become unchecked.

These changes add a :not(:disabled) to the jQuery check as well as moves the .not(':checked') into the original jQuery check since we want to see if the resulting input is checked and checking in the jQuery or outside if functionally the same.

I replicated the issue originally on Firefox 107.0 and Chrome 104.0.5112.81