search

PhantomGamers / SFP

This utility is designed to allow you to apply skins to the modern Steam client
MIT License
569 stars 11 forks source link

Old SFP patch method still works #127

Open re11ding opened 1 year ago

re11ding commented 1 year ago

Hey hey! This isn't really an issue persay, however library CSS patches that patch in the way 0.0.14 did still do work for the library and are a permanent (and revertable) means to patch Steam without having SFP open. Would it be possible to readd the patching method for the library?

PhantomGamers commented 1 year ago

It's not outside the realm of possibility but then there could be conflicts with the new patch method. It's not a high priority for me but I'll leave this open as I'm not against having this as an option.

FatheredPuma81 commented 1 year ago

Yea I don't want a program running in the background 24/7 for just Steam. So I've decided to revert to 0.0.15 until it breaks.

re11ding commented 1 year ago

Yea I don't want a program running in the background 24/7 for just Steam. So I've decided to revert to 0.0.15 until it breaks.

The method I mentioned does still only work with the library. I don't think you can modify other elements like the outer UI due to the switch to React, hence the switch to on the fly injection. There might be a better method figured out in the future, maybe something similar to how BetterDiscord works for Discord, but until then, they said they'd consider it. Just be patient and we'll see what the dev does.

FatheredPuma81 commented 1 year ago

The method I mentioned does still only work with the library. I don't think you can modify other elements like the outer UI due to the switch to React, hence the switch to on the fly injection. There might be a better method figured out in the future, maybe something similar to how BetterDiscord works for Discord, but until then, they said they'd consider it. Just be patient and we'll see what the dev does.

You mean something like this? https://raw.githubusercontent.com/FatheredPuma81/Full-Dark-Theme-for-Entirety-of-Steam/master/themes/Full%20Dark%20Mode/preview.png I'm currently using this and just had to toss everything into the library custom for it to work. Dunno about the Store, Community, or Big Picture mode though. Haven't gotten around to finishing my Skin yet.

re11ding commented 1 year ago

..Huh, maybe I was wrong on that? I'm digging the black on everything. And the old patcher makes it so you don't have to keep SFP running? What about context menus like when you right click a game? Are those also affected?

FatheredPuma81 commented 1 year ago

..Huh, maybe I was wrong on that? I'm digging the black on everything. And the old patcher makes it so you don't have to keep SFP running? What about context menus like when you right click a game? Are those also affected?

Omg you wouldn't believe how much of a PITA it was to find the colors for the context menus. They're literally a different window so I had to freeze the main Steam window with the debugger with them open, open a new Elements window, unfreeze it to get the Style side to update and show the colors, then finally hunt down the color >.>. If for some reason it closes after the unfreeze you have to do it all over again. But yea it works perfectly and even carries over to the In-game overlay too. Yea I just ran the old patcher once. The only issue is I have no idea how to change Steam's Windows Border color so there's a grey outline around the entire client and all the windows but that's not an SFP issue.

re11ding commented 1 year ago

Well then. I only asked because, in Valve's wise decision making, they made the context menus taller than a dime in height and I'm just sitting here going like ??? as it does nothing but add huge spacing between options that serve no purpose. I've downgraded to the version prior on Steam for the time being due to the memory leaks and stuff due to failed bug fixing on Valve's part, but once I feel things are stable enough, I'll update again. I'll want to modify the size of those context menus so it sounds like it'll be loads of fun doing that.

FatheredPuma81 commented 1 year ago

I'll want to modify the size of those context menus so it sounds like it'll be loads of fun doing that.

If you ever figure it out lemme know. I'd love to shrink them a bit too.