search

PhantomGamers / SFP

This utility is designed to allow you to apply skins to the modern Steam client
MIT License
554 stars 10 forks source link

The config file may not be writable relative to the binary #203

Open ShayBox opened 4 months ago

ShayBox commented 4 months ago

I packaged SFP_UI as an AUR package, but because it's packaged in a system directory (/usr/bin/SFP_UI), the config file SFP.config is not writable and settings do not save.

The config file appears to be JSON and should have the .json file extension, and be placed within the standard locations depending on the platform if the relative path is not writable.

This issue can affect Windows if the program gets packaged using a third-party installer, or package manager.
(Winget, Scoop, Chocolatey, etc.)

Windows: %AppData% Linux: $XDG_CONFIG_HOME with a fallback of $HOME/.config when not set macOS: ~/Library/Preferences

PhantomGamers commented 4 months ago

This is something I plan on changing in the next update. Currently I'm waiting for the next update of both avalonia and fluentavalonia to drop and then I'm going to upgrade to net8 and redo the configuration system, and when I do that I will take this into account.

GrahSebastian commented 2 months ago

This is a shame. I can get SFP and themes working with the AUR package, but the fact that I have to run the process in terminal first, than have to reconfigure all the setting in the gui and only then can start stream makes it too much of a hassle for daily use.

For Linux I would much prefer the option to just manage a config file and set it up as a service. The window and task icons as well as an open console feel bad for a utility that is meant to improve/customize visuals.

The fact that settings are not saved really brakes the deal. (depending on the DE the icon and console issues could be worked around)

I will track new releases in hope these issues can be fixed. It's a great tool and I appreciate all the effort taken. Just sad that is like 95% there and just so little is missing to make it great.

PhantomGamers commented 2 months ago

@GrahSebastian having to launch it from the terminal must be some specific problem with the aur package, I'm not too familiar with that. But with the version released on github, you can just double click on the executable to run it from your DE, no terminal necessary.

ShayBox commented 2 months ago

Yes, the AUR package does not include a desktop entry or icon, I'm still waiting for the programs config file to be moved, so the settings save, until then you either have to touch/chmod the location for the config or manually download and run the binary in a location that is writable.