PhantomVl / sccp_manager

SCCP Manager
35 stars 19 forks source link

SCCP Phone #3

Open dkgroot opened 7 years ago

dkgroot commented 7 years ago

Device Configuration

Not sure: but would this help ?

--- views/form.buttons.php  2017-10-04 14:09:15.552268071 +0200
+++ views/form.buttons.php  2017-10-04 14:09:15.552268071 +0200
@@ -23,9 +23,11 @@
 //print_r($hint_list);
 if (!empty($_REQUEST['id'])) {
     $dev_id = $_REQUEST['id'];
-    $db_butons = $this->get_db_SccpTableData('get_sccpdevice_buttons', array("id" => $dev_id));
+    //$db_buttons = $this->get_db_SccpTableData('get_sccpdevice_buttons', array("id" => $dev_id));  /*unused ? */
     $db_device = $this->get_db_SccpTableData('get_sccpdevice_byid', array("id" => $dev_id));
-    $max_buttons = $db_device['buttons'];
+    if (!empty($db_device['buttons'])){
+        $max_buttons = $db_device['buttons'];
+    }
     if (!empty($db_device['addon_buttons'])){
         $max_buttons += $db_device['addon_buttons'];
     }

Also i think 'get_db_SccpTableData', should check if the query was successfull, and handle any errors, before returning a potentially broken resultset/array.


Create a New Sub Section : "Enable/Disable Softkeys"

Create a New Sub Section : "Pickup" (Only show if Pickup/GPickup' is enable in previous Section)

Sub Section : 'Conference' (Only show if 'Conference' is enabled in previous Section)

Rename Sub Section : 'Device Network Function' -> 'Network'

dkgroot commented 7 years ago

Label : 'Music On Hold Class' : Automatically change with device Music Class if not set Explanaton:

  • So if the music class setting in the general setting changes,
  • and device->conference_music_class = NULL, to should show to the same filename as in the general section. (Not sure if that's easily done).
dkgroot commented 7 years ago

Nat = [Auto | On | Off] Default value is 'Auto'

In CLI they are shown as [On | Off | Auto | Auto (On) | Auto (Off) ]. Meaning:

I need to fix the sccp.conf.annotated if this is not clear


EarlyRTP = [none |offhook |immediate |dial |ringout | progress]

Default = 'Progress' 'Immediate' should not be offered to FreePBX Users (Expert Expert mode).

The value of earlyrtp specifies during which indication of an outgoing call, earlyrtp will be enabled. This would allow you to hear the PSTN announcement of 'This Call Costs 15 cents per minute' during the 'RINGING' indication. Before the call is connected.