Closed dkgroot closed 3 years ago
Hi Alex,
It looks like the order is correct. But there is still a little issue. When i select "Internal" on permit or localnet, the existing "0.0.0.0/0.0.0.0" entry is not replace, but we get two entries in sccp.conf:
deny = 0.0.0.0/0.0.0.0
permit = internal
permit = 0.0.0.0/0.0.0.0
localnet = internal
localnet = 0.0.0.0/0.0.0.0
Which would defeat the purpose of setting "internal" and causing a major security issue.
I also notice that at the end of the sccp.conf there are a number of "empty" entries like:
musicclass=default
externhost=
directed_pickup_context=
pickupgroup=
Those should not be present. If no value is set, the entry should be skipped.
Do you have an idea how to solve these two problems ? I am guessing "createDefaultSccpConfig" in Sccp_manager.class.php.
It's important to have deny before permit (just like all other channel drivers and the config files)
TODO: The resulting sccp.conf should also reflect this. Not sure if that is the case ?
Signed-off-by: Diederik de Groot dkgroot@talon.nl