Phanx / wow-addon-updater

Install and update World of Warcraft addons from the command line on Linux
zlib License
4 stars 1 forks source link

Update common.lua to use 'gio trash' instead of 'gvfs-trash' to trash... #8

Closed jukx closed 6 years ago

jukx commented 6 years ago

gvfs-trash is deprecated and spams the console with deprecation notices.

Compare e.g. http://manpages.ubuntu.com/manpages/artful/man1/gvfs-trash.1.html

Phanx commented 6 years ago

gio doesn't exist on my Linux Mint system, and apt search gio doesn't offer anything that looks relevant. I'm not interested in requiring additional packages, especially if those packages aren't available through my distro. Furthermore, gvfs-trash doesn't print anything, warning or otherwise, in my terminal. What distro are you using?

I'm happy to entertain suggestions for alternative trashing methods, but having them work on my own computer is kind of a hard requirement.

jukx commented 6 years ago

I see. Actually pretty strange that your Mint doesn't have gio, since it seems to be in Ubuntu since 12.04.

I'm using Arch Linux so I usually have the latest versions of programs. That's why I checked with the Ubuntu man pages which mark gvfs as deprecated since 17.10.

I just checked, in my distro, gio is part of the package glib2, maybe you have that available?

Phanx commented 6 years ago

Mint is currently on the Ubuntu 16.04 LTS package base, and all the glib2 related packages are already installed (I think by default) including the one that purports to provide "CLI for the GLib utility library", but no "gio" command is available.

Unless gvfs-trash actually doesn't work, I'm inclined to just mute the warnings.

Other alternatives would be to just delete things with no recoverability (seems bad) or move then to a dedicated backup location (okay, but wastes space and isn't obvious without rtfm).

jukx commented 6 years ago

Let's just mute it, then. gvfs-trash will probably be available in all distros for some time.