search

Pharap / ABSpriteEditor

A basic sprite editor designed for exporting and editing Arduboy sprites.
Apache License 2.0
7 stars 0 forks source link

Errors with Banner style image #10

Closed ace-dent closed 2 years ago

ace-dent commented 2 years ago

Imported a medium-large size banner image, with mask. On exporting as PlusMask format, data is totally garbled. Exporting as ExternalMask mask is offset to the right by 1-2px. Edit: Human error. The exported data is fine.

After exporting, on clicking into the editor area- crash! Unhandled exception:

System.ArgumentOutOfRangeException: Parameter must be positive and < Height.
Parameter name: y

Note: The editor window isn't scaling up the pixels to fill the viewable area.

Pharap commented 2 years ago

I believe the problem you are describing is the one that #11 has just fixed. I can't tell for definite without the full stack frame (the one that would have been dumped in the log file), but the error message is similar so I suspect it's likely.

Note: The editor window isn't scaling up the pixels to fill the viewable area.

It is. Zooming in one more notch puts part of the image outside the viewable area. The auto-scaling is designed to avoid that.

Outside

Pharap commented 2 years ago

I'm going to go out on a limb and assume #11 fixes this. If v0.1.2 doesn't fix this, I'll reopen the issue.

ace-dent commented 2 years ago

Seems fixed in current version. Thanks 👍