Pharap / ABSpriteEditor

A basic sprite editor designed for exporting and editing Arduboy sprites.
Apache License 2.0
7 stars 0 forks source link

Add 'Invert' tool #35

Closed ace-dent closed 2 years ago

ace-dent commented 2 years ago

Invert pixel values 0>1, 1>0.

Pharap commented 2 years ago

This is easier than some of the other suggestions, so I'll look into it when I have the time.

Unfortunately I don't have as much time to spare now as I did back at the start of August.

(Also, it would be an 'action button' rather than a 'tool', in the terminology of the project.)

Pharap commented 2 years ago

To Do:

ace-dent commented 2 years ago

Inspiration for icon design: https://www.flaticon.com/free-icon/invert-colors-button_61136 https://www.flaticon.com/free-icon/invert-tool_74155 https://www.flaticon.com/free-icon/invert_7663545

Pharap commented 2 years ago

As much as I appreciate the links, I had already had a look around and made some before mentioning that it was on my todo list.

Specifically I threw "Invert colour icon" at DuckDuckGo, it spat these out, and I ruled out quite a lot of them.

Oddly enough I did actually consider something similar to that first one, but I wasn't sure if it was easy enough to derive the purpose from the image (there's no real sense of 'action'), and I tend to put my own twist on things anyway, so I don't have to worry about copyright.


I actually came here to show off my current candidates:

A: InvertIcon16A B: InvertIcon16B C: InvertIcon16C D: InvertIcon16D

Scaled up versions if you can't be bothered to zoom in:

A: InvertIcon16AScaled B: InvertIcon16BScaled C: InvertIcon16CScaled D: InvertIcon16DScaled

(You may want to view them separately because GitHub's white background doesn't do them justice.)

I think A and D look the nicest, but C is the easiest to understand the meaning of.

I'm also considering something like:

E: InvertIcon16E InvertIcon16EScaled

Which matches in better with existing examples, but I was worred the red and green might confuse people.

Pharap commented 2 years ago

Three more for good measure: F: InvertIcon16F InvertIcon16FScaled G: InvertIcon16G InvertIcon16GScaled H: InvertIcon16H InvertIcon16HScaled

Pharap commented 2 years ago

By the way, the icon is actually the only thing that remains to be done. The actual implementation of the invert action only took a few moments.


It did briefly cross my mind that it might be useful to provide an invert tool (not action) that could invert a selected rectangular area instead of just the whole image. But that would take a fair bit longer and I'm not sure it's worth the effort.

ace-dent commented 2 years ago

They look great! My vote is H, then A, then G.