PharmGKB / PharmCAT

The Pharmacogenomic Clinical Annotation Tool
Mozilla Public License 2.0
120 stars 39 forks source link

Outside calls error #154

Closed Bioinf-usr closed 1 year ago

Bioinf-usr commented 1 year ago
whaleyr commented 1 year ago

There's a few issues here.

First, we will fix PharmCAT to not crash and give proper warnings about mismatching phenotype values from outside calls.

Second, IFNL3 does not use phenotype values in our system so you don't need to include that in your outside call file.

Third, the phenotype you specified for F5 (Favorable Response) is not a recognized phenotype value for PharmCAT. The recognized values are documented on our phenotypes page.

Fourth, I highly recommend not supplying both the diplotype and the phenotype. As stated in the docs you can do this but if your phenotype doesn't match one of our recognized phenotypes then we will use your phenotype and it will cause a mismatch for recommendations which rely on our recognized phenotype assignments. In this situation, supplying the diplotype calls should be sufficient to get recommendations.

Bioinf-usr commented 1 year ago
markwoon commented 1 year ago

@Bioinf-usr Can you please attach the original file with the problem? I'd like to reproduce the bug so that we can improve the error message, and I cannot reproduce it with what you provided. I'm guessing that it may be some formatting problem.

It would also be helpful if you could provide the full command line and output to help debug things.

What you provided (/opt/jdk-17.0.7/bin/java -jar pharmcat-2.7.1-all.jar -vcf -po test_input.tsv) should not work at all because you're not specifying a VCF file.

markwoon commented 1 year ago

Nevermind, I can reproduce now.

markwoon commented 1 year ago

I've got a fix for the stacktrace you reported and it will go out in the next PharmCAT release.

Bioinf-usr commented 1 year ago

Hi,

Just to add another possible bug here. When I tried to provide the IFNL3 and CYP4F2 calls from outside file. I get the following error.

java.lang.UnsupportedOperationException at java.base/java.util.AbstractMap.put(AbstractMap.java:209) at org.pharmgkb.pharmcat.Pipeline.call(Pipeline.java:287) at org.pharmgkb.pharmcat.PharmCAT.main(PharmCAT.java:166)

Here are my calls:

IFNL3 rs12979860 reference (C)/rs12979860 reference (C) CYP4F2 1/3

Am I missing something obvious? When I removed those calls from the file, it runs till the end. Otherwise, it crashes with the error message above.

Please let me know.

Thanks.

markwoon commented 1 year ago

This should be fixed in 2.8.0.