PharmaLedger-IMI / acdc-components

UC4 Anti-Counterfeiting Data Collaboration
MIT License
3 stars 4 forks source link

Refs30 fgt integration #31

Closed joaoluis-pdm closed 2 years ago

joaoluis-pdm commented 2 years ago

Issue #30

Includes the incremental DB change 0001

Hi! For the epi team, on the repo https://github.com/PharmaLedger-IMI/acdc-components/ there is a new branch (refs30_fgtIntegration) ready to merge to master.

Q1: Ok to merge to master ? (I ask because there is also a "develop" branch that someone else might be using... It does not break anything, and even if no SQL upgrade is performed, everything should continue to work fine).

Info1: On next deployment to one of the environments ourside of PDM, you may reset the SQL environment entirely, or upgrade it incrementally. (If you don't do any of those, and just update the code, it will still work fine, and if someone accesses the Finish Goods Traceability feature, it will display the incremental SQL upgrade instructions:

Database schema outdated. You probably need to execute the script backoffice-backend/lib/sql/acdc/change/do_00001_fgtIntegration/run.sql. Root cause:No AppResource.key=fgt.url,locale=nul

)

Info2: Due to the acdc/backoffice-backend being allowed to issue REST client requests to the internet (and the URL can be configured on the web interface - which is kind-of-public for now), the REST requests are limited to domains ending in *.pharmaledger.pdmfc.com. Feel free to request more domains, as it is hardcoded for now - to prevent mis-use of the servers that host it (https://github.com/PharmaLedger-IMI/acdc-components/blob/a38736bcacfe7c6ad703c927063178ca9cf15649/backoffice-backend/src/acdc/event.service.ts#L71).

(More docs on https://raw.githubusercontent.com/PharmaLedger-IMI/acdc-components/refs30_fgtIntegration/pdm-deploy-tools/doc/fgtIntegration.png and https://raw.githubusercontent.com/PharmaLedger-IMI/acdc-components/refs30_fgtIntegration/pdm-deploy-tools/doc/fgtIntegrationSequence.png).