PharmaLedger-IMI / epi-workspace

ePI use case main repository
MIT License
4 stars 0 forks source link

App Scan GS1 Composite Code #101

Closed maherpa2 closed 2 years ago

maherpa2 commented 3 years ago

PL user story: #93 (see full overview for additional information)

Description: Changes to the App and decoding in order to be able to scan additional codes:

Acceptance criteria's: positive tests

negative tests / error path testing

Process scenario:

Additional information: N/A

andrejstas commented 3 years ago

Current open-source solution ZXing (https://github.com/zxing/zxing) is NOT capable of scanning this code.

maherpa2 commented 3 years ago

@andrejstas we had a call with Scandit and are expecting some information from them this week. Their SDK can manage this code and many other codes. will keep you updated as we get more information.

mppub commented 3 years ago

TESTING NOTES: This task can be tested once new version is deployed of you can test it locally when you run npm run dev-install

steps:

  1. go to "patient wallet"
  2. click to the menu on top left and choose "Settings"
  3. in the section "Setup Scanning" paste the valid scandit api key and hit "set" button - this you can generate in https://ssl.scandit.com/licenses (CREATE WEB SDK LICENSE KEY) or will be handled to you by me so please contact me on michal.podhradsky@merck.com treat the api key as password and do not share it publicly please
  4. go to the scan page and start scanning

a few more notes: the codes that can be scanned are according to the assignement:

rite2bala commented 3 years ago

Will be able to test this once the API license key is re-activated.