search

PharmaLedger-IMI / epi-workspace

ePI use case main repository
MIT License
5 stars 4 forks source link

JSON upload for batch and product accepts values for greyed out fields #1072

Closed steinso2 closed 1 year ago

steinso2 commented 1 year ago
  1. I created JSON and set flags to true, even they are grayed out and shouldn't be maintainable (because the functions are deactivated)
  2. result is: fields were accepted and changed, see result in UI image
salboaie commented 1 year ago

@steinso2 is this an important fix for MVP1? it will require new validation code for something that should not happen by accident...

steinso2 commented 1 year ago

Even if we only consider the field which is part of the scope of MVP1: "enable expired expiration date", it shouldn't be changeable using json. We can control it procedural but it has to be clear to all, because I was surprised that it is changeable by json.

In functional requirement we stated; Only fields used in MVP1 are allowed to be used in json file (procedural control in user manual). If flags/fields in json has different value than defined in the rules for MVP1, it shall fail from processing and shown in “failed import logs” with the relevant error message

Lets see what the others think

salboaie commented 1 year ago

@adiganga2002 add validation rules to stop anything that is not for MVP1