search

PharmaLedger-IMI / epi-workspace

ePI use case main repository
MIT License
5 stars 4 forks source link

Audit Trail for failed uploaded product and batch shows wrong command #1080

Closed steinso2 closed 1 year ago

steinso2 commented 1 year ago

Step:

  1. create json for a complete new product and keep one mandatory field empty
  2. upload json and get error message Result: the command shows that "editing" the product fails. But it should show: CREATION of a new product fails. Same in the Audit log: e.g. 2113111111140 Edited product - fail

Command and Audit log has to differentiate if a product was failed to be CREATED vs failed to be UPDATED/EDITED

salboaie commented 1 year ago

@steinso2 when we generate that message we don't know if is creation or update. Changing now the whole flow for just this little detail looks wrong and risky. It is acceptable to just put at reason like "Message pre-validation Failed" ?

steinso2 commented 1 year ago

@salboaie lets discuss in the audit trail meeting on Wednesday. The rules for the audit trail are quite strict and James needs to decide.

salboaie commented 1 year ago

@adiganga2002 decision: put as reason : "Fail - See details"