search

PharmaLedger-IMI / epi-workspace

ePI use case main repository
MIT License
5 stars 4 forks source link

#100 App Scan non-Serialized Datamatrix Code #138

Closed rite2bala closed 2 years ago

rite2bala commented 3 years ago

Extra error message on mobile app screen when serial number is left blank.

adiganga2002 commented 3 years ago

Hi @rite2bala, can you please attach a print screen with this Extra error message and steps to reproduce ?

maherpa2 commented 3 years ago

@adiganga2002 @rite2bala when producing a non-serialized batch then the Datamatrix code would have GTIN (AI01), Batch (AI10)Number, Expiry Date (AI17). The code would not have the serial Number (AI21). A code that I saw had AI21 and it had a value of 0. This is incorrect as AI21 should not be in the code at all. If clarification is needed then please reach out to me.

rite2bala commented 3 years ago

Hello @adiganga2002

Please ignore the issue regarding extra error message for now. I am unable to reproduce the error.

As per the comments mentioned in the https://github.com/PharmaLedger-IMI/epi-workspace/issues/111 . There are three data matrices in the description. All three of the data matrices, do not have AI21 Serial number.

I created a sample code using the app on epiqa and scanned using gs1 interpreter: https://gs1.github.io/interpretGS1scan/camera.html

image

Result: Raw output:

010897767123573921010ZK219117210324 Interpretation: GS1 identifiers 01 GTIN 08977671235739 10 BATCH/LOT ZK2191 **21 SERIAL 0** 17 USE BY OR EXPIRY 2021-03-24 Equivalent identifiers Human-readable AI syntax (01)08977671235739(17)210324(10)ZK2191(21)0 Native AI syntax 01089776712357391721032410ZK2191210 GS1 Digital Link URI https://id.gs1.org/01/08977671235739/10/ZK2191/21/0?17=210324 The Serial Number must not be a part of the code.
rite2bala commented 3 years ago

Just noticed that Patrick has also posted the "extra message's screenshot" - similar screenshot on the story #111

https://user-images.githubusercontent.com/58995303/109262928-a5b06280-7802-11eb-9298-b7447e2d2d34.png

"It also seem to cause the App to crash but I could not re-create this. I am not reporting this as a bug because the system was only designed to ready serialized Datamatrix codes.

rite2bala commented 3 years ago

image

Hello @adiganga2002 @skutner I was able to reproduce the error by scanning the above datamatrix code. This was a very old product code created prior to the deployment.

The error appears differently in iOS and in Android .

Could you please check?

URL:https://epiqa.westeurope.cloudapp.azure.com/leaflet-wallet/loader/ pls change the domain to epiqa

cc: @nhrishi

nhrishi commented 3 years ago

I tested this today again for the below code in eqiqa environment. I got the same error for the new product and batch.

https://barcode.tec-it.com/en/DataMatrix?data=(01)28888388884889(17)210430(10)KB9261

Screenshot 2021-04-16 at 3 55 15 PM
maherpa2 commented 3 years ago

@nhrishi that Datamatrix code you gave the link to is not encoded correctly.

rite2bala commented 3 years ago

I created a similar code as Hrishikesh and observed that I do not receive the error: https://barcode.tec-it.com/en/DataMatrix?data=(01)23332255466678(17)210430(10)RL0137

skutner commented 3 years ago

Hi @nhrishi @rite2bala . Is this still a bug or we can close this issue?

mppub commented 3 years ago

Just tested for the Scandit library, it works as expected for all above mentioned codes(the ones in comments included)

mppub commented 3 years ago

@rite2bala this issue shall be resolved soon - can we close it already? if there are any more problems with it please create a new bug from it and lets tackle it separately thank you

rite2bala commented 3 years ago

***Updated comment:

Current understanding: A non-serialized batch is one where valid serial numbers are not uploaded. It is not any explicit setting to indicate batch is non-serialized.

Case 1

  1. We created a batch and updated it with valid serial numbers. Saved the product.

  2. Reopened the batch and then deleted/reset the serial numbers.

  3. We then disabled the serial number check for the batch using the setting: image

  4. Used the below tool to create a 2d matrix without serial number i.e. without (21) tag: https://barcode.tec-it.com/en/DataMatrix?data=(01)09812376129473(17)240524(10)RV5163

  5. When the above code is scanned – an error appears on the mobile app.

This error also forces the expiry date check to malfunction... i.e when the expiry date in the above code is from step 4 is changed, the error in expiry date check doesn't change.

Case 2

  1. For a non-serialised batch – We create a 2d matrix with test serial number (any number after 21 tag) https://barcode.tec-it.com/en/DataMatrix?data=(01)09812376129473(17)240524(10)RV5163(21)1231

  2. It works fine - because the serial number check was disabled in step 3 of case 1 and we are supplying an invalid serial number.

Observation: The current scanner is unable to interpret data matrix without 21 tag.

rite2bala commented 3 years ago

hi @mppub We were able to test only now because we got a stable interface without critical errors. This error would have to remain in QA stack until fixed.

Please do let me know if you were able to reproduce the error or need any additional explanation or would like to correct my testing approach.

Thank you.