search

PhasecoreX / docker-ut2004-server

Docker image for a UT2004 server, running as a non-root user
GNU General Public License v3.0
31 stars 7 forks source link

Fix for recent Google Drive API changes #20

Closed spijet closed 7 months ago

spijet commented 7 months ago

Google Drive now requires the user to send the unique uuid parameter when confirming the "this file is big and may contain viruses" warning. The problem is that this parameter is hidden inside the HTML form present on the warning page, so it has to be parsed out of said page before it can be added to the download URL. This PR adds a pup HTML parser package to the image and uses it to extract all the needed parameters directly from the HTML warning page.

The pup package itself is small (around 1MiB), so it shouldn't make the image much larger than it was before. In my local tests the image is ~4 MiB larger:

ut2004                             latest      55d6b21fe9e4   25 minutes ago   202MB
phasecorex/ut2004-server           latest      e38fd4b5d591   6 days ago       198MB

Disregard all of the above, we've found a much simpler fix in #19. I just tested it and it works well for me. :)

spijet commented 7 months ago

@PhasecoreX, I just uploaded the simple version of the fix, so the PR is ready to merge. Please squash my commits when merging if possible, so we don't pollute the commit history with a discarded pup solution. :)

PhasecoreX commented 7 months ago

Looks good, thank you very much!