search

Phasedio / webapp

1 stars 0 forks source link

visiting FEED page duplicates all items in feed #23

Closed daveriedstra closed 8 years ago

daveriedstra commented 8 years ago

Issue in PhasedProvider with setting a watch on all team members for each controller. Should be a quick fix (ie, FBRef.child().off(handler)).

daveriedstra commented 8 years ago

addressed in branch issue23 w commit ce79b34422dccf6deeb53f0cb4e0501c33c570ab.

getMemberHistory() double checks each status as it comes in to see if it's in the history already or not. Seems like excessive work, but getMemberHistory() needs to be called on controller load for cases where Feed page isn't the first visited in the app -- eg, coming from Tasks, which will register the Firebase.on() handler in setUpTeamMembers(), but 'value' needs to be triggered in order to populate the team history.

Alternative solution might be to always keep the team's history in memory, but this could result in unnecessary bandwidth (how concerned are we about that?).

brianbest commented 8 years ago

To answer your question @daveriedstra bandwidth optimization is a concern but not the highest. Once we have our feature sets down pat I'm sure we will come back for optimizations. :D