search

PhaserEditor2D / PhaserEditor

A friendly IDE to develop HTML5 games based on the Phaser framework.
https://phasereditor2d.com
Eclipse Public License 1.0
327 stars 45 forks source link

I noticed the GPU went loco with PhaserEditor #127

Closed j2l closed 4 years ago

j2l commented 5 years ago

Version

Description

I'm evaluating your solution but have multiple questions: First, I noticed the GPU went loco with PhaserEditor. Like if a bitcoin mining was running 😄 Do you know why? image

Let's say it was not the smoothest experience.

PhaserEditor2D commented 5 years ago

Hi, thanks for reporting these bugs, I created separate issues:

https://github.com/PhaserEditor2D/PhaserEditor/issues/128

https://github.com/PhaserEditor2D/PhaserEditor/issues/129

PhaserEditor2D commented 5 years ago

Please, can you tell me the editors (I mean, scene editor, pack editor, js editor, ...) open when the GPU gets like that?

Does it happen always? With few images?

j2l commented 5 years ago

I just noticed the GPU fan started. I wasn't doing anything special. Very few images (from Flying Dragon).

I exited and relaunched PhaserEditor and it worked normally (high CPU at first, and some GPU when dragging an image then 1% when idle). I don't know what happened but it was stable in pumping resources, enough time to do a screenshot.

PhaserEditor2D commented 5 years ago

I should create some preferences to disable the screenshot builders, them could be the reason. The first time you create a project it creates the screenshots, the second time it reuses them. Please, can you try to create a completely new project again, with the Flying dino template and confirm the GPU gets a high usage percent?

j2l commented 5 years ago

OK, I took some time to pin the problem and made an (unpublished) video: https://youtu.be/YetmsVP7MWo Note that if I hadn't removed the watermelon animation, it would still use 80% GPU after minutes (and the GPU fan kicks in), so I suspect a glitch somewhere.

My GPU is GTX 970. so 80% is a lot of resources for a 2D platformer.

PhaserEditor2D commented 5 years ago

Thanks very much for the video! I am on it. Please send me hello to developers@phasereditor2d.com

PhaserEditor2D commented 5 years ago

I think this is related to the embedded browser or how we are using Phaser in it. This will take some time. I keep you updated.

PhaserEditor2D commented 5 years ago

Hi, I received your email but the reply was rejected. You can PM in twitter https://twitter.com/PhaserEditor2D

j2l commented 5 years ago

Hmm, thanks. It means I might have issues with my DMARC settings.

On Tue, Jul 2, 2019 at 5:32 PM Phaser Editor notifications@github.com wrote:

Hi, I received your email but the reply was rejected. You can PM in twitter https://twitter.com/PhaserEditor2D

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PhaserEditor2D/PhaserEditor/issues/127?email_source=notifications&email_token=AAAP6LJZTOYGQL6WAKN4KN3P5NYH7A5CNFSM4H42EF4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZBVI7I#issuecomment-507729021, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAP6LI2I72ZCQFJT7XHF3TP5NYH7ANCNFSM4H42EF4A .

PhaserEditor2D commented 5 years ago

Please, can you try to reproduce the same behavior and then Refresh the browser? It looks like Phaser gets into a lot of requestAnimationFrame. image

j2l commented 5 years ago

I was learning more about PhaserEditor when I see this ticket and noticed that GPU was low but CPU was high. I hit refresh and CPU went down. So I guess, it's a fix for now. Really hope it will be automatic :)

PhaserEditor2D commented 5 years ago

Hi, thanks for testing it.

I will reopen the issue because yet I don't realize what is going with Phaser and the browsers.

PhaserEditor2D commented 5 years ago

I think I found the problem. The common is that Phaser runs a paint loop with a high FPS. We, in Phaser Editor, stop that loop and request a paint just when needed. For I reason I should find now, when you drop an object, the loop may start again and a lot of painting are requested and never stop. I should release a new version as soon as I fix the problem.

PhaserEditor2D commented 5 years ago

Some progress on this.

The problem is that when you add a new texture, the editor has to start the Phaser loader to load it. For some reason, it starts the game loop, and we do not stop it at time. Please, uncompress the zip I attach here and paste its content into the folder:

PhaserEditor2D/plugins/phasereditor.scene.ui.editor.html_2.1.1.20190623/html/out

Accept to replace the files.

You should look a white label in the left corner of the Scene Editor. That label displays the number of painting calls. Please, try to reproduce the error and see that number does not go crazy and go up forever, even if the editor is idle.

If it works for you, I should release a new version of the editor this week, with the fix.

Thanks

image

j2l commented 5 years ago

OK, the initial drag problem seems fixed but now, when I start and do nothing, it seems to hold the CPU in hostage until I refresh the internal browser.

It's a slightly different problem since it's the CPU and the painting calls remain under 21 on idle.

I write another ticket for issue with selection behavior

PhaserEditor2D commented 5 years ago

when I start and do nothing, it seems to hold the CPU in hostage until I refresh the internal browser.

I will try to reproduce that behavior.

the painting calls remain under 21 on idle.

That's the correct behavior. The painting calls should increment only when you do modifications in the scene and it needs to be repainted.