search

PhasesResearchLab / pySIPFENN

Python python toolset for Structure-Informed Property and Feature Engineering with Neural Networks. It offers unique advantages through (1) effortless extensibility, (2) optimizations for ordered, dilute, and random atomic configurations, and (3) automated model tuning.
https://pysipfenn.org
Other
20 stars 3 forks source link

Suggestion: `Calculator(verbose=False)` should not print (or tqdm) any output #18

Open bocklund opened 3 months ago

bocklund commented 3 months ago

The verbose output is helpful to see what's going on and get realtime feedback, but sometimes it's hard to find my output among all of pysipfenn's output. I'd like to be able to hide all the output (at least on the happy path, if stuff is breaking or not right, then being noisy is the right thing to do IMO).

amkrajewski commented 3 months ago

Thanks for the feedback @bocklund ! As always, it is very much appreciated!

The idea behind this switch was to make printouts verbose vs. concise rather than on vs. off, but you are right that a no-printout option would be nice to have. I was actually thinking about it like two months ago - whether or not to turn it into a "verbosityLevel" switch with Flase, 0, 1, ... options.

Another option I like, especially in the context of debugging, would be to have both verbose and printout switches, where Calculator with the default printout=True acts just like now, while printout=False will direct messages, verbose or concise, into an internal logger variable that could be accessed when needed. What are your thoughts on that?

amkrajewski commented 3 months ago

I created a new branch, improve_CalculatorPrintout, for this purpose.