search

Phazorknight / Cogito

Immersive Sim Template Project for GODOT 4
MIT License
865 stars 98 forks source link

Quest: Steal the laptop - win condition doesn't get triggered - item checker issue? #204

Closed Phazorknight closed 4 months ago

Phazorknight commented 4 months ago

Cogito and Godot Engine Version: beta 202405.15 Godot 4.2.1 stable

Description: The Steal the laptop quest in the Lobby scene doesn't seem to work correctly and I can't figure out how to fix it.

Reproduction steps:

  1. Pickup CEO Laptop.
  2. Place it in the fridge.
  3. Close the fridge.
  4. According to print logs, the item checker looks in the fridge but doesn't find it.

Expected behavior: The item checker should be able to find the CEO laptop and then send a signal for the quest updater to complete/win the quest.

The quest works correctly with the regular laptop, so it seems like the item checker script is working. I'm not sure why it can't seem to find the CEO laptop specifically.

BlueSeoul commented 4 months ago

Hello, I’ve noticed this issue too. It seems like the resource file that the quest checker is looking for isn’t being assigned correctly.

The inventory checker is looking for <Resource#-9223371869082610428> or res://COGITO/InventoryPD/Items/Cogito_LaptopReal.tres

But instead the Ceos laptop seems to be getting a sub resource from the tscn scene: <Resource#-9223371939194599117> or res://COGITO/DemoScenes/DemoPrefabs/laptop_real.tscn::Resource_ufnk8

I've tried ways of redirecting or trying to remove the sub resource, but I’m not quite sure how to remove or change resources to nodes.

Phazorknight commented 4 months ago

@BlueSeoul you were on the right track. I saw that the item resource assigned to the pickup component of the laptop_real.tscn was set to local, making it kinda "unique". This caused issues with the item checkers as the ids wouldn't match anymore (besides some other issues like the item description and size not being correct in the inventory).

I've re-assigned the item resource in the packed scene and it immediately worked. This update is live in https://github.com/Phazorknight/Cogito/commit/314916c60e5563dd829c95076c8b992df422d762

Closing this issue as resolved.