search

PheWAS / PheWAS

The PheWAS R package
118 stars 53 forks source link

PheWAS::phewas_ext does not behave as expected #69

Open lauragails opened 6 months ago

lauragails commented 6 months ago

Hello, Thank you for this software! When I was running using outcome=dx and predictors=names(phenotypes)[-1] I did not specify anything about additive.genotypes=FALSE because I expected this to be set to FALSE, since I did not input genotypes into my matrix.

I would have expected this addition: if (missing(genotypes)) { if (!missing(predictors)) genotypes = predictors additive.genotypes=FALSE else stop("Either genotypes or predictors must be passed in.") }

That being said, now that I know this is the default, it's not a big deal.

Thank you again! Laura

RobertJCarroll commented 3 months ago

Hello there. Thank you for this comment. Would you like to make a PR with this recommended change?