search

Phelton2 / blockchain-developer-bootcamp-final-project

0 stars 0 forks source link

Feedback #1

Open abakus00 opened 2 years ago

abakus00 commented 2 years ago

Hi @Phelton2

I have just tested your contract. It seems you only have two passing tests. The requirement was to have 5 passing tests. Please correct me if you believe I am wrong. Please screenshot attached. If I am right, are you able to add more tests to meet the requirement in the next day or two? Screenshot 2022-02-04 at 01 59 57 .

Phelton2 commented 2 years ago

Ok thanks for the feedback

On Thu, Feb 3, 2022, 9:04 PM abakus00 @.***> wrote:

Hi @Phelton2 https://github.com/Phelton2

I have just tested your contract. It seems you only have two passing tests. The requirement was to have 5 passing tests. Please correct me if you believe I am wrong. Please screenshot attached. If I am right, are you able to add more tests to meet the requirement in the next day or two? [image: Screenshot 2022-02-04 at 01 59 57] https://user-images.githubusercontent.com/69770572/152460276-edb6fec8-6b9a-4c83-85d4-01e08f4935e6.png .

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGOL2WNBWKF32WNKO7TUZMX37ANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

Phelton2 commented 2 years ago

Sorry to reply again but is that the only thing that is wrong with my project

On Thu, Feb 3, 2022, 9:04 PM abakus00 @.***> wrote:

Hi @Phelton2 https://github.com/Phelton2

I have just tested your contract. It seems you only have two passing tests. The requirement was to have 5 passing tests. Please correct me if you believe I am wrong. Please screenshot attached. If I am right, are you able to add more tests to meet the requirement in the next day or two? [image: Screenshot 2022-02-04 at 01 59 57] https://user-images.githubusercontent.com/69770572/152460276-edb6fec8-6b9a-4c83-85d4-01e08f4935e6.png .

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGOL2WNBWKF32WNKO7TUZMX37ANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

abakus00 commented 2 years ago

Hi @Phelton2! So the fact you only had two passing texts was my last check .

If you can correct this I will have a final review BUT the best thing is to check and satisfy yourself first that all the requirements have been met before resubmitting as there might not be another opportunity for a feedback loop.

I hope that makes sense! Amma

Phelton2 commented 2 years ago

Ok, thanks.

On Fri, Feb 4, 2022, 2:02 PM abakus00 @.***> wrote:

Hi there! So there was the fact there you only had two passing texts. I also faced an issue where your dapp did not get further than displaying a 'Processing' message. I have asked Coogan to check if it was just me having an issue.

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1#issuecomment-1030267187, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGKLBVZORE2XOBRIUXLUZQPDDANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: <Phelton2/blockchain-developer-bootcamp-final-project/issues/1/1030267187@ github.com>

Phelton2 commented 2 years ago

Good afternoon May I have until Wednesday to resubmit my project please

On Thu, Feb 3, 2022, 9:04 PM abakus00 @.***> wrote:

Hi @Phelton2 https://github.com/Phelton2

I have just tested your contract. It seems you only have two passing tests. The requirement was to have 5 passing tests. Please correct me if you believe I am wrong. Please screenshot attached. If I am right, are you able to add more tests to meet the requirement in the next day or two? [image: Screenshot 2022-02-04 at 01 59 57] https://user-images.githubusercontent.com/69770572/152460276-edb6fec8-6b9a-4c83-85d4-01e08f4935e6.png .

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGOL2WNBWKF32WNKO7TUZMX37ANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

Phelton2 commented 2 years ago

Thank you for your patience with me. I have completed the tests and pushed it to GitHub

On Thu, Feb 3, 2022, 9:04 PM abakus00 @.***> wrote:

Hi @Phelton2 https://github.com/Phelton2

I have just tested your contract. It seems you only have two passing tests. The requirement was to have 5 passing tests. Please correct me if you believe I am wrong. Please screenshot attached. If I am right, are you able to add more tests to meet the requirement in the next day or two? [image: Screenshot 2022-02-04 at 01 59 57] https://user-images.githubusercontent.com/69770572/152460276-edb6fec8-6b9a-4c83-85d4-01e08f4935e6.png .

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGOL2WNBWKF32WNKO7TUZMX37ANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

abakus00 commented 2 years ago

Hi @Phelton2 Thank you for your update.

I have just checked your repository and cannot see any revisions to your code/commits after January 15th. See screenshot attached.

Screenshot 2022-02-11 at 11 04 53

If you think there is a mistake you might be best to follow up directly with Coogan. Wishing you the best! Amma

Phelton2 commented 2 years ago

I am having trouble connecting to that git repository but here is the revised version https://github.com/Phelton2/blockchain-developer-bootcamp-final-project-master-4

On Fri, Feb 11, 2022 at 11:04 AM abakus00 @.***> wrote:

Thank you for your update. I have just checked your project and cannot see your revised code.

[image: Screenshot 2022-02-11 at 11 04 53] https://user-images.githubusercontent.com/69770572/153581304-a34bafc9-e10b-4d81-8209-44d42ff46255.png

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1#issuecomment-1036366309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGKQC3VNYSDCL7PDUU3U2UXQ3ANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: <Phelton2/blockchain-developer-bootcamp-final-project/issues/1/1036366309@ github.com>

abakus00 commented 2 years ago

Hi @Phelton2 Thanks for your update. I have run the tests again and can now see you have 5 passing tests in the new repository. However, it seems your original GitHub is now 'corrupt'

Screenshot 2022-02-14 at 23 29 19 Screenshot 2022-02-14 at 23 29 06

If you are not able to resolve the issue, please DM Coogan in Discord or send him an email to get his advise. Coogan oversees the certifications.

You might want to mention that I am satisfied that your project, in the new repository, now passes the required checks. If it is easier, just share the link to this feedback.

Well done!

Best regards Amma

Phelton2 commented 2 years ago

Will do, thanks!

On Mon, Feb 14, 2022 at 6:38 PM abakus00 @.***> wrote:

Hi @Phelton2 https://github.com/Phelton2 Thanks for your update. I have run the tests again and can now see you have 5 passing tests in the new repository. However, it seems your original GitHub is now 'corrupt'

[image: Screenshot 2022-02-14 at 23 29 19] https://user-images.githubusercontent.com/69770572/153964445-ec3f999f-ad23-4657-816d-93476ed8446b.png [image: Screenshot 2022-02-14 at 23 29 06] https://user-images.githubusercontent.com/69770572/153964452-5abe3b14-71e3-4e6b-9f8c-ea297110d8f1.png

If you are not able to resolve the issue, please DM Coogan in Discord or send him an email to get his advise. Coogan oversees the certifications.

You might want to mention that I am satisfied that your project, in the new repository, now passes the required checks. If it is easier, just share the link to this feedback.

Well done!

Best regards Amma

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1#issuecomment-1039685329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGPBI3NAXMKGZVGS6BDU3GG77ANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: <Phelton2/blockchain-developer-bootcamp-final-project/issues/1/1039685329@ github.com>

Phelton2 commented 2 years ago

Question what do you mean by corrupt

On Mon, Feb 14, 2022 at 6:38 PM abakus00 @.***> wrote:

Hi @Phelton2 https://github.com/Phelton2 Thanks for your update. I have run the tests again and can now see you have 5 passing tests in the new repository. However, it seems your original GitHub is now 'corrupt'

[image: Screenshot 2022-02-14 at 23 29 19] https://user-images.githubusercontent.com/69770572/153964445-ec3f999f-ad23-4657-816d-93476ed8446b.png [image: Screenshot 2022-02-14 at 23 29 06] https://user-images.githubusercontent.com/69770572/153964452-5abe3b14-71e3-4e6b-9f8c-ea297110d8f1.png

If you are not able to resolve the issue, please DM Coogan in Discord or send him an email to get his advise. Coogan oversees the certifications.

You might want to mention that I am satisfied that your project, in the new repository, now passes the required checks. If it is easier, just share the link to this feedback.

Well done!

Best regards Amma

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1#issuecomment-1039685329, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGPBI3NAXMKGZVGS6BDU3GG77ANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: <Phelton2/blockchain-developer-bootcamp-final-project/issues/1/1039685329@ github.com>

abakus00 commented 2 years ago

HI @Phelton2, 'corrupt' might be the wrong choice of words. Perhaps, 'damaged' is better.

Look at the screenshots I shared yesterday. You will notice many of the folders have disappeared from your original repository. That is, the contracts, migrations and test folders are no longer visible.

Phelton2 commented 2 years ago

ok thanks

On Tue, Feb 15, 2022 at 7:20 AM abakus00 @.***> wrote:

HI @Phelton2 https://github.com/Phelton2, 'corrupt' might be a price choice of words. Perhaps, 'damaged' is better.

Look at the screenshots I shared yesterday. You will notice many of the folders have disappeared from your original repository. That is, the contracts, migrations and test folders are no longer visible.

— Reply to this email directly, view it on GitHub https://github.com/Phelton2/blockchain-developer-bootcamp-final-project/issues/1#issuecomment-1040207685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOELGM2Q4DYVCIKUB6RFK3U3JAKBANCNFSM5NQR4Y3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: <Phelton2/blockchain-developer-bootcamp-final-project/issues/1/1040207685@ github.com>