PhenoApps / Field-Book

https://fieldbook.phenoapps.org
GNU General Public License v2.0
52 stars 54 forks source link

[REQUEST]: Maintain Obs Vars list associated with DeltaBreed experimental dataset #1014

Open SCYarnes opened 4 months ago

SCYarnes commented 4 months ago

Description

Current Behavior

Limits of current behavior

Pull two datasets from DeltaBreed into FB.

When DS2 is loaded, all 8 observation variables are now erroneously selected for DS1.

Alternatives

Desired Dataset Behavior

Additional Context

Experimental (Trial) Dataset is not in BrAPI

Pete doesn't think it needs to be in BrAPI

Hey Shawn, Field Book has the ability to manually enable/disable traits. I think it would be relatively trivial for them to track ObsVars downloaded with a dataset, then enable/disable them automatically when a user changes fields in the app. This functionality would need to be added to Field Book to solve your issue either way, whether it uses the current BrAPI import methods, or if BrAPI had an explicit dataset endpoint that linked everything. I would recommend opening an issue/feature request on the Field Book GitHub (if you haven't already) and perhaps copying this explanation into the #field-book channel to make sure the right people see it.I'm not sure I see the need for a new BrAPI endpoint right now, based on this use case. ObsUnits, ObsVars, and Observations can all be linked together and queried together by a trialDbId or studyDbId depending on how you organize your experiments. Field Book is currently retrieving all its data by studyDbId but it isn't maintaining the relationship between ObsVar and Study after pulling the data.

Duplicates BI-2249