PhenoApps / Field-Book

https://fieldbook.phenoapps.org
GNU General Public License v2.0
53 stars 54 forks source link

[BUG]: BrAPI field import germplasm attributes not imported in some cases #1055

Open nickpalladino opened 1 month ago

nickpalladino commented 1 month ago

Description

As part of the BrAPI field import process a germplasm search call is made and the results are used to populate the pedigree and synonyms attributes for display on the collect page. When the search call responds with a searchResultDbId and a GET call is made to get the results by Field Book, if the results are not ready by the time the first call is made they will not be imported. This seems to be because the retry logic in Field Book is not handling that case properly and is only making the single request. Problem seems to be in the BrAPIServiceV2::executeBrapiSearch while loop exiting before it should.

Expected behavior

No response

Field Book version

No response