PhenoApps / Field-Book

https://fieldbook.phenoapps.org
GNU General Public License v2.0
52 stars 54 forks source link

Skip entries update and bugfix #990

Closed bellerbrock closed 4 months ago

bellerbrock commented 5 months ago

Description

Provide a summary of your changes including motivation and context. If these changes fix a bug or resolves a feature request, be sure to link to that issue.

Fixes bug where skip entries for all traits preference would crash collect activity by attempting to set traitboxview to a trait that wasn't visible.

closes #987

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

Checklist:

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

Skip entries update and bugfix
bellerbrock commented 4 months ago

@chaneylc thanks. And agreed re the setting description. They have been updated in the v6 settings PR to ` Skip Entries

Disabled
<string name="preferences_behavior_skip_entries_with_data">Arrows skip entries that already have values for the current trait</string>
<string name="preferences_behavior_skip_entries_across_all_traits">Arrows skip entries that already have values for all traits</string>`