search

Phenomics / ontolib

A modern Java library for working with (biological) ontologies.
https://ontolib.readthedocs.org
Other
9 stars 2 forks source link

[Please read details] Change date so we can use phenotype_annotation.tab #12

Closed johntiger1 closed 7 years ago

johntiger1 commented 7 years ago

For phenotype_annotation.tab, the date format is of the form 2013-06-23. For negative_phenotype_annotation.tab the date format is as used currently ( 2013.06.23)

Note that if you use this commit, you will need to comment out the corresponding test: HpoDiseaseAnnotationParserTest.java

holtgrewe commented 7 years ago

Thank you for your patch!

Maybe we could create a loop over a String formats[] = {"yyyy.MM.dd", "yyyy-MM-dd"} and use the first date that fits? Could you adjust your patch accordingly?

@drseb could you review the format of the tab files?

drseb commented 7 years ago

Will fix in one of the next release to use iso-date.sent from mobile-------- Originalnachricht --------Betreff: Re: [Phenomics/ontolib] [Please read details] Change date so we can use phenotype_annotation.tab (#12)Von: Manuel Holtgrewe An: Phenomics/ontolib Cc: Sebastian Köhler ,Mention Thank you for your patch! Maybe we could create a loop over a String formats[] = {"yyyy.MM.dd", "yyyy-MM-dd"} and use the first date that fits? Could you adjust your patch accordingly? @drseb could you review the format of the tab files?

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Phenomics/ontolib","title":"Phenomics/ontolib","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Phenomics/ontolib"}},"updates":{"snippets":[{"icon":"PERSON","message":"@holtgrewe in #12: Thank you for your patch!\r\n\r\nMaybe we could create a loop over a String formats[] = {\"yyyy.MM.dd\", \"yyyy-MM-dd\"} and use the first date that fits? Could you adjust your patch accordingly?\r\n\r\n@drseb could you review the format of the tab files?"}],"action":{"name":"View Pull Request","url":"https://github.com/Phenomics/ontolib/pull/12#issuecomment-325565438"}}}

holtgrewe commented 7 years ago

Replaced by #14.