search

Phenomics / ontolib

A modern Java library for working with (biological) ontologies.
https://ontolib.readthedocs.org
Other
9 stars 2 forks source link

HpoID vs TermID #24

Closed johntiger1 closed 6 years ago

johntiger1 commented 7 years ago

What is the difference between the two? They appear to do the same thing in HpoDiseaseAnnotation.java

cmungall commented 7 years ago

We're also wondering the same thing. I'd like to use ontolib across a wider set of ontologies, it's not scalable to keep adding in new seemingly identical implementations.

This also applies to the Term interface and HpoTerm etc.

cmungall commented 7 years ago

Also all the implementations of TermRelation. And what is VegetableTermRelation

drseb commented 7 years ago

@holtgrewe we should have another session. I think there might be better designs here.

drseb commented 6 years ago

@johntiger1 TermID is probably from ontologizer.

We will discuss the other design issue offline and via email with @cmungall and others.