Phenomics / ontolib

A modern Java library for working with (biological) ontologies.
https://ontolib.readthedocs.org
Other
9 stars 2 forks source link

Bug in MpoOboFactory #32

Open pnrobinson opened 6 years ago

pnrobinson commented 6 years ago

Similar to an error that was fixed in HpoOboFactory on August, the original code

 final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");

on line 143 of MpoOboFactory.java assumed that the mp.obo file would include milliseconds in its date stamp. mp.obo does not include milliseconds and so we could not parse the mp.obo file. We changed this line to

 final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'");

Following this, we were able to successfully parse the entire mp.obo file We have made a corresponding PR

holtgrewe commented 6 years ago

See comment in PR.