Pherakki / BlenderToolsForGFS

A Blender plugin for importing and exporting GFS files.
GNU General Public License v3.0
22 stars 3 forks source link

Facial animations broken on some (maybe all) characters #157

Open Cleep2 opened 6 months ago

Cleep2 commented 6 months ago

Describe the bug Some facial animations (EM[CHARACTER_ID].GFS) seems to badly load for some models

Environment Blender 3.6 Plugin version: 0.2.1 (also tested the latest dev) Reproduced on P5R PC, P5R PS4 and P5 PS3 files.

To Reproduce Steps to reproduce the behavior:

I also tried that with Maruki (1014), Joker (0001) and they also have the 01 (and many other) broken. But Ryuji (0002) seems to not be broken (or less broken)

Notes:

Expected behavior The facial animations works properly, for example Ryuji seems to work better image

Files Character models:

Animation:

Additional context I think there might be an issue with the rotation of the bones, because when I tried to investigate I noticed that if I "swap" x and y rotation it "looks" closer to what I would expect for the "closed eyes". But I have close to no knowledge on quaternions so it might just be some coincidence. image image

Pherakki commented 1 month ago

Thanks for the report and sorry for taking a long time to react to this. I'm pretty sure I know what the ultimate cause of this is... your note about a 90 degree rotation seeming to fix it basically confirms the thought... but I'm a bit worried that fixing this might be quite non-trivial. I've done a preliminary investigation already but will need to dedicate some more time here to figure out why these bones seem to break the rules.